[Gambas-user] [Gambas-Notification] [Git][gambas/gambas][master] Correctly fix the READ instruction without leaking memory.

[Benoît Minisini]

Le 24/05/2018 à 18:12, Tobias Boege a écrit :
> On Thu, 24 May 2018, Benoît Minisini via Notification wrote:
>> Benoît Minisini pushed to branch master at Gambas / gambas
>>
>>
>> Commits:
>> 35e98598 by gambas at 2018-05-24T13:09:51Z
>> Correctly fix the READ instruction without leaking memory.
>>
>> [INTERPRETER]
>> * BUG: Correctly fix the READ instruction without leaking memory.
>>
> 
> I need a clarification on this. Did you temporarily introduce
> a memory leak in READ while fixing my Bug #1329 yesterday or
> was there one even before that? We have a German Gambas user
> who is experiencing OOM errors after some hours of watching
> a process which is generating data by the second.
> 
> Regards,
> Tobi
> 

I introduced it in the first fix.

A buffer is allocated to read the stream data, but that buffer must be 
freed.

Before the first fix, the buffer was freed twice if there was an error.

After the first fix, the buffer was never freed.

After the second fix, the buffer should be correctly freed once.

Regards,

-- 
Benoît Minisini