[Gambas-user] Hopefully, an optimisation for gb.db.postgresql

[GMail]

On Sat, 2011-12-17 at 16:31 +0100, Benoît Minisini wrote:
> Hi,
> 
> I have factorized your optimization and the code from the field_info 
> function, and put it in revision #4280.
> 
> Can you try it and check that I didn't break everything? And that 
> optimization is always there of course!
> 
> Regards,
> 

Good morning Benoît,

I have checked rev #4280 and my test harness indicates that all works
and the speed gains are there for the expected calls (Connection.Create
and Connection.Edit) and all the db methods still work as expected.

One question though!  In both the original code and the new code you
check that the column is not null and has a default value.  I don't
quite understand the need for this and have a feeling that the code as
it is will not detect serial columns where the postgresql NOT NULL is
not set (there is no requirement in postgresql that a column with any
default value be NOT NULL).

regards
Bruce