From adrien.prokopowicz at ...176... Sat Jan 9 13:56:33 2016 From: adrien.prokopowicz at ...176... (Adrien Prokopowicz) Date: Sat, 09 Jan 2016 13:56:33 +0100 Subject: [Gambas-devel] gb.xml.html: MatchFilter() causes infinite loop In-Reply-To: <20151005153930.GA657@...693...> References: <20151005153930.GA657@...693...> Message-ID: Le Mon, 05 Oct 2015 17:39:30 +0200, Tobias Boege a ?crit: > Hi Adrien, > > attached is a project with a simple HTML file which causes XmlElement's > MatchFilter() method to enter an infinite loop. The project code tests > of a given node whether it matches the ".title" selector. To trigger the > infinite loop, the node apparently must have a "class" attribute such as > > class="title nowrap" > > Since this is my last week of holidays, I thought I'd have some fun and > hunt the bug myself. It was in > element.cpp:XMLElement_AttributeContains(). > Because I didn't understand your string search code there, I rewrote it > from scratch. But I don't have many gb.xml projects lying around to test > it. It fixes the infinite loop in my current project, though, and > delivers > the expected results. I will commit the changes to trunk now and would > like > you to confirm that it doesn't break things elsewhere. > > Regards, > Tobi > Hi Tobias, First, sorry for the (very) late reply. As I said in another thread, the past few months have been very tough for me. I took a look at your code, and it works for my other projects. Thanks you for fixing this. :) Regards, -- Adrien Prokopowicz