[Gambas-devel] Gentoo ebuild and patches

[Benoit Minisini]

On vendredi 05 septembre 2008, Boian Berberov wrote:
> Gambas Developers,
>
> I have been writing an updated ebuild (making a new package) for your
> software for Gentoo Linux.  You can view some of the progress here:
> http://bugs.gentoo.org/show_bug.cgi?id=229821
>
> Quite a few patches have accumulated that are needed to build Gambas for
> Gentoo.  Please review these patches and consider them for inclusion:
> gambas-2.7.0-r1-gb.qt-QT_LDFLAGS.patch -
> http://bugs.gentoo.org/attachment.cgi?id=161148
> gambas-2.7.0-r1-help-GB_INIT_SHORT.patch -
> http://bugs.gentoo.org/attachment.cgi?id=161149
> gambas-2.8.0-sdl-component-name.patch -
> http://bugs.gentoo.org/attachment.cgi?id=163347
>
> If you reject certain patches, could you explain why you cannot adopt them.
> I may make alternative patches and try to submit those at a later date.
>
> Boian Berberov

Hi,

I looked at your patches at bugs.gentoo.org, and here are my comments:

*** gambas-2.7.0-r1-gb.qt-QT_LDFLAGS.patch

I don't understand this patch. @QT_LDFLAGS@ is logically needed, they are the 
flags coming from pkg-config, so they should not be removed.

*** gambas-2.7.0-r1-help-GB_INIT_SHORT.patch

OK. There is no need to use GB_INIT there.

*** gambas-2.7.0-r1-libtool-and-FLAGS.patch

Please explain the difference between AC_LIBLTDL_CONVENIENCE and AC_WITH_LTDL.

Why are you removing the "--enable-optimization" configure flag?

*** gambas-2.7.0-r1-remove-libltdl-from-main.patch

Why are you removing the use of the local libltdl sources?

*** gambas-2.8.0-help-path.patch

OK. It seems to be a fix, and a better way of doing the same thing. Can you 
confirm?

And why did you replace $(LN_S) by "ln -s"?

*** gambas-2.8.0-libtool.patch

Please explain the difference between AC_LIBLTDL_CONVENIENCE and AC_WITH_LTDL.

*** gambas-2.8.0-sdl-component-name.patch

Why did you rename the component name?

*** gambas-2.8.2-FLAGS.patch

Why did you remove the "--enable-optimization" configure flag?

Why did you force optimization to "-O3"? I carefully use it on specific source 
files, because gcc is not reliable with this optimization, and sometimes -O3 
can be slower than -Os.

*** gambas-2.8.2-app-Makefile-install.patch
*** gambas-2.8.2-comp-Makefile-install.patch
*** gambas-2.8.2-examples-Makefile-install.patch

OK. It seems to be a better and cleaner way to do the same thing. Can you 
confirm?

Well, thanks anyway for fixing my autoconf && automake files. This 
configuration system is horrible when you try to do something uncommon.

Regards,

-- 
Benoit Minisini