[Gambas-devel] MySQL class ready

[Benoit Minisini]

On mercredi 23 avril 2008, David Villalobos Cambronero wrote:
> Hi all
>
> I have finished all changes suggested by Benoit:
>
> 1- Now MySQL.class is part of DB and Connection class.
>
> 2- I removed the MySQL.Connection property, since the connection info can
> be retrived from DB and Connection Clasess.
>
> 3- Added/Removed some properties and functions.
>
> 4- There is a new property called Confirm, that will ask the user to
> execute or not the statement.
>
> 5- Translation updated (for spanish) :-)
>
> 6- Quoted some unquoted symbols.
>
> 7- I' made some new functions like Dumps, Load Data from files into tables,
> and Views (at least in a simple way). Any idea for something that should be
> present?
>
> 8- Bonit, I'll appreciate your comments.
>
> Best regards
>
> David
>

Hi, David.

Your component has been imported in the subversion tree. Now you can work 
directly on it.

It is now the Gambas part of the gb.db.mysql component, so it is located 
inside he gb.db.mysql/src directory.

I quickly saw may problems in it yet:

* _MySQL should be "Create Static".

* If you have a "Create Static" class (for example _MySQL) that exists just 
for being the value of a property, you don't have to instanciate it each time 
you need it. Just return the static instance by using the class name. I have 
done the needed modifications in _MySQL so that you can see what I mean. You 
should do the same changes for the other classes.

* Error messages do not end with a point, and should not be translatable.

* You should read the documentation carefully before using a feature: 
Process_Error is not a event raised because there is an error in Gambas, but 
when a running process writes on its standard error output.

* 'Length' in english, not 'Lenght'. Your error messages sometimes are not 
really in english too!

* 'Charset' instead of 'CharSet'.

* I use '$' for global variables only, to see immediately the difference with 
local variables. Maybe you should do the same, and not use this special 
character for both?

That's all at the moment. :-)

Regards,

-- 
Benoit Minisini