Re: Background and theme files for gb.highlight

[gbWilly <gbWilly@xxxxxxxxxxxxxx>]

On Friday, April 3rd, 2026 at 00:37, Benoît Minisini <benoit.minisini@xxxxxxxxxxxxxxxx> wrote:

> Le 02/04/2026 à 13:21, Benoît Minisini a écrit :
> > Le 02/04/2026 à 12:55, gbWilly a écrit :
> >> It came to my attention that Background in a themes file is no longer
> >> applied to my TextEditor control in Gambas 3.21.5
> >> This really sucks big time. The application is build in 3.19.6 and
> >> runs fine there shows all as I like and want it.
> >>
> >  > [...]
> >
> > The reason of the change is the new syntax highlighting system.
> >
> > There are three points that must be taken into account:
> >
> > 1) The TextHighlighterTheme class has now an explicit 'Background'
> > property, that is filled by the "Background" entry of the theme file if
> > it exists.
> >
> > 2) The TextHighlighterTheme adapts automatically to a dark background
> > unless its 'Adaptive' property is set to FALSE (the old behaviour).
> >
> > 3) The background color of the TextEditor control is now prioritary, and
> > is applied to the theme when the Theme property is set, so that the
> > theme can adapt to that background color.
> >
> > So, to get the old behaviour, you should:
> >
> > - Set the Adaptative property of the theme to FALSE.
> > - Save the Background color property of the theme.
> > - Assign the theme to the editor.
> > - Apply the saved background color to the editor Background property.
> >
> > If you just apply the theme to the editor, you get the new behaviour:
> > the theme is automatically adapted to the background color of the
> > editor, which is by default the background color chosen by the user for
> > its desktop interface.
> >
> > Sorry for the inconvenience, and tell me if it works for you.
> >
> 
> Hi,
> 
> In the last commit on master, the TextHighlighterTheme now takes the
> Background color specified inside a theme, and the TextEditor will use
> it if defined, instead of its Background property. Moreover, in that
> case, no automatic color adaptation is done.
> 
> It should restore backward-compatibility. Can you try it and tell me?
> 
> If it works, the fix will be backported to the next 3.21.6 version.

That sounds great.
As soon as OSb updates I'll be testing and reporting back.

Thank you,

gbWilly

GambOS
Gambas3 for Debian/Ubuntu

...there is always a Catch if things go wrong!