Re: New search implementation in the IDE

[Bruce Steers <bsteers4@xxxxxxxxx>]

My fixes...

It seems when you open the panel the second time and hit Browse the search
results do not show.  but , if you click the combobox that says "All files"
and just select "All files" again then it all works as expected, (something
did not initialize properly)

So i added this to the end of FSearch.Form_Show()
  cmbSearchIn_Click

Now no problems with it.

I also added this to FSearch.Form_Hide()

  Action["find", FMain].Value = False

that toggles the IDE search button back to off

And this is not so much a "fix" but it is my preference that the search
results does not auto-close when i close the upper search panel
So i changed FDebugInfo.SetSearchListInfo() that runs with no sText when
the upper panel hides.
Everything was hidden if no sText so i changed a couple of sText to
gvwFind.Rows.Count >0

Public Sub SetSearchListInfo(Optional sText As String)

  lblBrowse.Text = sText
  lblBrowse.Visible = sText
  gvwFind.Visible = gvwFind.Rows.Count > 0
  lblNotFound.Visible = Not sText
  ShowTab(TAB_SEARCH, gvwFind.Rows.Count > 0)

End

With that the lower search panel now only auto-hides if there are no
results showing.

As for your fixes Christof i think a good fix for (2) would be if a TextBox
still showed the placeholder if it has focus and only remove the
placeholder when text is entered.
That's the problem because the search panel opens with the Search textbox
having focus so its placeholder is hidden.

And maybe a tooltip on the Search box
Enter = Find next in current file
Ctrl+Enter = Find in all files (Browse)


Respects
BruceS



On Fri, 1 Nov 2024 at 19:39, Christof Thalhofer <chrisml@xxxxxxxxxxx> wrote:

> Am 01.11.24 um 19:35 schrieb Bruce Steers:
>
> >     I don't know what 'pressing find all' means. So I cannot confirm.
> >
> >
> > sorry it's the browse button (magnifying glass)
> >
> >
> >     Instead of pressing a button try CTRL-ENTER after you typed your
> search
> >     string. That opens the search results and is currently a hidden
> >     feature.
> >     Did you mean that?
> >
> >
> > Yes , i think hitting find all (sorry that's the browse button) and
> > Ctrl-Enter is the same thing.
>
> No.
>
> After you typed the search string, ENTER finds the next occurrence of
> the string. Ctrl-Enter also opens the *search result tab*.
>
> The old search opens the *search result tab* automatically when you
> search in *all files* or in *all source files*.
>
> > It's after that though , then when i close the upper search panel the
> > search results panel vanishes never to return.
> >
> > hmm Ctrl-Enter isn't making a difference but it seems if i only press
> > Ctrl-F to open the search panel and not use the IDE Find button then
> > it's okay.
>
> > Only using the toggle button makes it go wrong.
> > it's gotta be something to do with that.
>
> Yes. The toggle button doesn't initiate any search functionality, it
> just switches the visibility of the *search form* on and off and the
> *search result tab* only off.
>
> Now I can confirm: The toggle button switches both off but when switched
> on it only makes the search form visible again but not the *search
> result tab*.
>
> Next issue is:
>
> When you after that want to open the *search result tab* by hitting
> Ctrl-Enter it instead opens the console. That's weird.
>
> Alles Gute
>
> Christof Thalhofer
>
> --
> Dies ist keine Signatur
>
>
>